fix: Remove serialization of computed statistics (#3980)

Author: iamareebjamal

app/controllers/admin/events/list.js

@@ -64,14 +64,14 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
        },
        {
          name          : 'Sessions',
-         valuePath     : 'eventStatisticsGeneral',
+         valuePath     : 'generalStatistics',
          cellComponent : 'ui-table/cell/cell-sessions',
          width         : 90
 
        },
        {
          name          : 'Speakers',
-         valuePath     : 'eventStatisticsGeneral',
+         valuePath     : 'generalStatistics',
          cellComponent : 'ui-table/cell/cell-speakers-dashboard',
          width         : 90
        },

app/controllers/admin/users/view/events/list.js

@@ -41,14 +41,14 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
       },
       {
         name          : 'Sessions',
-        valuePath     : 'eventStatisticsGeneral',
+        valuePath     : 'generalStatistics',
         width         : 90,
         isSortable    : false,
         cellComponent : 'ui-table/cell/cell-sessions-dashboard'
       },
       {
         name          : 'Speakers',
-        valuePath     : 'eventStatisticsGeneral',
+        valuePath     : 'generalStatistics',
         cellComponent : 'ui-table/cell/cell-speakers-dashboard',
         isSortable    : false
       },

app/controllers/events/list.js

@@ -43,12 +43,12 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
       },
       {
         name          : 'Sessions',
-        valuePath     : 'eventStatisticsGeneral',
+        valuePath     : 'generalStatistics',
         cellComponent : 'ui-table/cell/cell-sessions-dashboard'
       },
       {
         name          : 'Speakers',
-        valuePath     : 'eventStatisticsGeneral',
+        valuePath     : 'generalStatistics',
         cellComponent : 'ui-table/cell/cell-speakers-dashboard'
       },
       {

app/models/event.js

@@ -95,27 +95,27 @@ export default ModelBase.extend(CustomPrimaryKeyMixin, {
   /**
    * Relationships
    */
-  type                   : belongsTo('event-type'),
-  topic                  : belongsTo('event-topic'),
-  subTopic               : belongsTo('event-sub-topic'),
-  location               : belongsTo('event-location'),
-  sessions               : hasMany('session'),
-  sponsors               : hasMany('sponsor'),
-  microlocations         : hasMany('microlocation'),
-  tracks                 : hasMany('track'),
-  tickets                : hasMany('ticket'),
-  orders                 : hasMany('order'),
-  socialLinks            : hasMany('social-link'),
-  emailNotifications     : hasMany('email-notification'),
-  speakers               : hasMany('speaker'),
-  invoice                : hasMany('event-invoice'),
-  speakersCall           : belongsTo('speakers-call'),
-  stripeAuthorization    : belongsTo('stripe-authorization'),
-  eventStatisticsGeneral : belongsTo('event-statistics-general'),
-  tax                    : belongsTo('tax'),
-  copyright              : belongsTo('event-copyright'),
-  sessionTypes           : hasMany('session-type'),
-  user                   : belongsTo('user', { inverse: 'events' }),
+  type                : belongsTo('event-type'),
+  topic               : belongsTo('event-topic'),
+  subTopic            : belongsTo('event-sub-topic'),
+  location            : belongsTo('event-location'),
+  sessions            : hasMany('session'),
+  sponsors            : hasMany('sponsor'),
+  microlocations      : hasMany('microlocation'),
+  tracks              : hasMany('track'),
+  tickets             : hasMany('ticket'),
+  orders              : hasMany('order'),
+  socialLinks         : hasMany('social-link'),
+  emailNotifications  : hasMany('email-notification'),
+  speakers            : hasMany('speaker'),
+  invoice             : hasMany('event-invoice'),
+  speakersCall        : belongsTo('speakers-call'),
+  stripeAuthorization : belongsTo('stripe-authorization'),
+  generalStatistics   : belongsTo('event-statistics-general'),
+  tax                 : belongsTo('tax'),
+  copyright           : belongsTo('event-copyright'),
+  sessionTypes        : hasMany('session-type'),
+  user                : belongsTo('user', { inverse: 'events' }),
 
   customForms     : hasMany('custom-form'),
   attendees       : hasMany('attendee'),

app/routes/events/view/index.js

@@ -22,7 +22,7 @@ export default class extends Route.extend(EmberTableRouteMixin) {
       roleInvites  : await eventDetails.query('roleInvites', {}),
       sessionTypes : await eventDetails.query('sessionTypes', {}),
       socialLinks  : await eventDetails.query('socialLinks', {}),
-      statistics   : await eventDetails.query('eventStatisticsGeneral', {}),
+      statistics   : await eventDetails.query('generalStatistics', {}),
       orderStat    : await eventDetails.query('orderStatistics', {}),
       tickets      : await eventDetails.query('tickets', {}),
       roles        : await this.store.findAll('role')

app/serializers/event.js

@@ -10,26 +10,13 @@ export default ApplicationSerializer.extend(CustomPrimaryKeyMixin, {
     subTopic  : 'event-sub-topic',
     copyright : 'event-copyright'
   },
-  normalize() {
-    const payload = this._super(...arguments);
-    payload.data = this.addLinks(payload.data);
-    return payload;
-  },
 
-  addLinks(event) {
-    event.relationships.eventStatisticsGeneral = {
-      links: {
-        related : `/v1/events/${event.id}/general-statistics`,
-        self    : `/v1/events/${event.id}/general-statistics`
-      }
-    };
-    event.relationships.orderStatistics = {
-      links: {
-        related : `/v1/events/${event.id}/order-statistics`,
-        self    : `/v1/events/${event.id}/order-statistics`
-      }
-    };
-    return event;
+  serialize() {
+    const json = this._super(...arguments);
+    delete json.data.relationships['general-statistics'];
+    delete json.data.relationships['order-statistics'];
+
+    return json;
   }
 
 });