Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display number of Results fetched #314

Open
1 of 2 tasks
rupav opened this issue Nov 4, 2017 · 9 comments
Open
1 of 2 tasks

Display number of Results fetched #314

rupav opened this issue Nov 4, 2017 · 9 comments

Comments

@rupav
Copy link
Member

rupav commented Nov 4, 2017

I'm submitting a ...

  • bug report
  • feature request

Current behavior:

There is no display of number of results fetched.
Expected behavior:

Diplaying the number of results fetched.

I would like to work on it.

@rupav
Copy link
Member Author

rupav commented Nov 4, 2017

@bhaveshAn @cclauss @shashank-sharma your views on it?

@cclauss
Copy link
Contributor

cclauss commented Nov 4, 2017

Can we please get more detail on the output format that you propose?

  • Today: print('Google parsed: ' + str(urls))

Do you propose?:

  • print('Google ({}): {}'.format(len(urls), urls))
  • print('{} results from Google: {}'.format(len(urls), urls))
  • print('{} results from Google:\n{}'.format(len(urls), urls))
  • print('{} results from Google:\n{}'.format(len(urls), ‘\n’.join(str(url) for url in urls)))
  • print('{} results from Google:\n{}'.format(len(urls), json.dumps(urls, indent=4)))
  • other?

@rupav
Copy link
Member Author

rupav commented Nov 4, 2017

@cclauss I am having a problem about the codebase, pinged you on gitter. Please see. Thanks.

@cclauss
Copy link
Contributor

cclauss commented Nov 4, 2017

Is you issue that when you run locally, you see nothing printed?

@rupav
Copy link
Member Author

rupav commented Nov 7, 2017

@cclauss I opened this issue for displaying number of results on the website itself.

@cclauss
Copy link
Contributor

cclauss commented Nov 7, 2017

👌 Now I understand.

@starlord1311
Copy link
Contributor

can i take up this issue? @cclauss @rupav

@rupav
Copy link
Member Author

rupav commented Dec 2, 2017

@starlord1311 yeah you can. Let's confirm if it's needed or not. @bhaveshAn @shashank-sharma please let us know if this feature is needed.

@mariobehling
Copy link
Member

It would be nice to have that, but I am unclear if we are really able to get this data easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants