Feat/forge lint verbosity #12693
Open
Feat/forge lint verbosity #12693
+59
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipanshuhappy
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
0xrusowsky
requested changes
Nov 29, 2025
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
besides the lint-related comment that i left, why are you modifying cast?
please remove all of that
Comment on lines
-106
to
+110
| .with_severity(if severity.is_empty() { None } else { Some(severity) }) | ||
| .with_severity(if severity.is_empty() { | ||
| Some(vec![Severity::Low]) | ||
| } else { | ||
| Some(severity) | ||
| }) |
Contributor
There was a problem hiding this comment.
this is incorrect, what we should do is that when no severity is informed we exclude the Severity::Gas lints
additionally forge lint is also invoked via forge build, so rather than changing the mulitple entry points, it may be better to change the behavior in the lint crate
Contributor
Author
There was a problem hiding this comment.
Ah Got it. On it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12635
Motivation
Solution
I made the severity by default to be low
PR Checklist