Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forge tests bucketing #2267

Closed
Draggu opened this issue Jul 1, 2024 · 0 comments
Closed

Forge tests bucketing #2267

Draggu opened this issue Jul 1, 2024 · 0 comments
Assignees
@ksew1
Labels
snforge

Comments

@Draggu
Copy link
Contributor

Draggu commented Jul 1, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

Currently we isolate scarb cache per test, this solves issue with parallel tests writing to same cache. With new scarb plugins in current shape we must rebuild plugin which makes running our tests very slow. We should split tests into buckets. In each bucket we have only one cache and run tests synchronously. This way we compile plugin only few times (ones per bucket/thread)
@github-actions github-actions bot added the new label Jul 1, 2024
@Arcticae Arcticae removed the new label Jul 10, 2024
@ksew1 ksew1 mentioned this issue Jul 18, 2024
Merged
5 tasks
ksew1 added a commit that referenced this issue Aug 5, 2024
@ksew1
Add cache dir for forge e2e tests (#2325)
eaa8118 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2267

## Introduced changes

<!-- A brief description of the changes -->

- Added cache directory to e2e tests, to avoid rebuilding `forge_std`.

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [x] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
@ksew1 ksew1 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksew1 ksew1

Labels
snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arcticae @Draggu @ksew1