Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate tests compilation failing when using code from core::internal #2397

Closed
cptartur opened this issue Aug 26, 2024 · 1 comment · Fixed by #2420
Closed

Investigate tests compilation failing when using code from core::internal #2397

cptartur opened this issue Aug 26, 2024 · 1 comment · Fixed by #2420
Assignees
@integraledelebesgue
Labels
bug Something isn't working snforge

Comments

@cptartur
Copy link
Member

cptartur commented Aug 26, 2024 •
edited
Loading

All tests except for test_u96 from this file https://github.com/keep-starknet-strange/garaga/blob/7d4571b2dd31ea66951b35ad7a3ab1f91b9880f5/src/src/lib.cairo#L27 lead to compilation failure. Investigate why is this the case.
@github-actions github-actions bot added the new label Aug 26, 2024
@foundry-rs foundry-rs deleted a comment Aug 26, 2024
@piotmag769 piotmag769 added the bug Something isn't working label Aug 26, 2024
@cptartur cptartur removed the new label Aug 28, 2024
@obatirou obatirou mentioned this issue Aug 29, 2024
Merged
9 tasks
@integraledelebesgue integraledelebesgue mentioned this issue Aug 29, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@integraledelebesgue
Added missing Cairo core implicits to BUILTINS (#2420)
6255060 
<!-- Reference any GitHub issues resolved by this PR -->

Closes
[#2397](#2397 (comment))

## Introduced changes
- Added missing implicits present in Cairo `core` but not ignored by
`forge-runner`: `RangeCheck96`, `AddMod`, `MulMod`

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [x] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@integraledelebesgue integraledelebesgue

Labels
bug Something isn't working snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing Cairo core implicits to BUILTINS foundry-rs/starknet-foundry
5 participants
@cptartur @piotmag769 @integraledelebesgue and others