You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which components does the task require to be changed? (think hard pls)
snforge
Description
Config got from Scarb.toml is stored in ForgeConfigFromScarb struct, but firstly toml is mapped into RawForgeConfig, partially validated, and then mapped into ForgeConfigFromScarb. It can be done without RawForgeConfig abstraction by implementing Deserialize Trait for ForgeConfigFromScarb, ForkTarget, and so on.
Which components does the task require to be changed? (think hard pls)
snforge
Description
Config got from
Scarb.toml
is stored inForgeConfigFromScarb
struct, but firstly toml is mapped intoRawForgeConfig
, partially validated, and then mapped intoForgeConfigFromScarb
. It can be done withoutRawForgeConfig
abstraction by implementingDeserialize Trait
forForgeConfigFromScarb
,ForkTarget
, and so on.Flow that should be refactored:
starknet-foundry/crates/forge/src/scarb.rs
Lines 26 to 31 in 3d857eb
Validation for
ForkTarget
that should be implemented in the deserialize method:starknet-foundry/crates/forge/src/scarb/config.rs
Lines 91 to 115 in 3d857eb
ForkTarget::new
should be replaced, by creation from deserializing json.The text was updated successfully, but these errors were encountered: