Skip to content

Loopy simlinks #230

@twiggler

Description

@twiggler

Suppose I acquire the following paths:

mkdir -p dir1/dir2/dir3
ln -s dir1/dir2/dir3 dir1/sym_dir_lnk

I get:

[2025-04-03 11:50:35,567] [ERROR] - Skipping collection of /vmfs/volumes/nfs_shizzle/dir1/dir2/dir3, breaking out of symlink loop
\*\*\* Acquiring specified paths
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2/dir3
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2/dir3 succeeded
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2 succeeded
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk
- Collecting symlink /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk to: fs/$rootfs$/vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk
- Collecting symlink /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk succeeded
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2/dir3
- Skipping collection of /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2/dir3, breaking out of symlink loop
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk succeeded
- Collecting path /vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1 succeeded

Done collecting artifacts:
cli-args
    failure: path:/vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/dir2/dir3
    success: symlink:/vmfs/volumes/6787a7fc-8afc8b90-95e8-52540056ac6d/dir1/sym_dir_lnk
------------------------------------------------------------
  Module |    Success |    Failure |    Missing |      Empty
------------------------------------------------------------
cli-args |          1 |          1 |            |           
------------------------------------------------------------
   Total |          1 |          1 |          0 |          0
------------------------------------------------------------

The director is captured and present in the archive.

Expected

An info messages at most.
A Failure makes little sense to me, since the contents are captured,
and there is no loop.

If the direction of the symlink was reversed, pointing from dir3 to dir1 then the warning makes more sense to me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions