Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyMonitor - request #28

Open
murko69 opened this issue Dec 18, 2024 · 6 comments
Open

MyMonitor - request #28

murko69 opened this issue Dec 18, 2024 · 6 comments
Labels
feature New feature or request

Comments

@murko69
Copy link

murko69 commented Dec 18, 2024

I asked about this many years ago - but now when we have some issues with localization I need to modify my idea....

The monitor is active on two pages. Team page and MyHT

On a team page you can see this:
Screenshot(13)

I would like that count (18) to be added to the Monitor on the MyHT-page.
Just very simple like this:
Screenshot(14)

Within the same h2-tag would work fine, just add a space in-between!
Then it's like an enhancement and no new feature really and best of all - no need to translate :)

@murko69
Copy link
Author

murko69 commented Dec 18, 2024

Part from the 'very small' enhancement I asked for in the previous post I also have a much larger request when it comes to MyMonitor.
If this is doable, I'm aware of the current "translation issues" so this might be a request for the future!

After a few cut n' paste I made a simple model on how I would like to see MyMonitor in the next version!

There are three main team-types that can be added to the monitor. Senior teams, youth teams and NT.
Here's an example on how it looks today with 23 added teams, sorted by Team Names!

MyMonitor1

I would like to suggest 'BLOCKS'!
Three blocks for each team-type mentioned above.

That would maybe look like this, if we add the counter(s) and also the suggested blocks, still sorted by Team Names!

MyMonitor2

As you can see, there's total counter (23) but also separate counters for each block (18, 1, 4 in my example)!
Everything still sorts as you chose above (manually, names, IDs), but within the blocks.

I think also the blocks themselves should be sortable if somehow maybe want NT at the top - I suggest making them 'draggable' as the different forums in HT-settings, or the shortcut icons for that matter!

And if you ask me - I think it looks awesome 😜

@unnecessarydave unnecessarydave added the feature New feature or request label Dec 18, 2024
@unnecessarydave
Copy link
Collaborator

I think it looks very nice.

We could even have the tab-like headers you have at the top of each block function as tabs (optionally), so that it takes up less vertical space. That would be a bit more work of course, as I think we'd want generic 'html/css tabs' code so other modules could use that presentation style in the future.

I have to ask though. What is the reasoning for the counter(s)? Not that it's difficult to add or anything. I'm just curious.

@murko69
Copy link
Author

murko69 commented Dec 18, 2024

I have to ask though. What is the reasoning for the counter(s)? Not that it's difficult to add or anything. I'm just curious.

I'm admin for a few private leagues (using the weekday friendly) and as soon as a team registers interest to compete, I'll add them to the Monitor. If there is a counter directly on MyHT-page it's just faster to spot how many teams we will be, instead of having to count 'pairs' or switch to a team page to see the counter there!

Also - the split counters makes even more sense then, since I might have added NT- and/or youth -teams as well.

So basically it's a "convenience-counter" :D

We could even have the tab-like headers you have at the top of each block function as tabs (optionally), so that it takes up less vertical space.

Totally agree - I just thought my first suggestion would be less work!
I actually 'borrowed' my cut n' paste block headers from the tabs under player details as you probably noticed

About tabs!
There is a feature at the bottom of the monitor to import games to HT-Live (it's "exporting to" really who cares 😉.....).
If I'm currently on the future tab for NT and chose the "import senior matches", would that work since those teams/matches are not even shown?

Maybe need to change that import feature as well to work only on the active tab?

@murko69
Copy link
Author

murko69 commented Dec 24, 2024

@unnecessarydave I have another question about MyMonitor
HT have put a min-height on the dashboard calendar like

.calendarWrapperOuter {
 min-height: 400px;
}

That makes for pretty big white gap between the calendar and MyMonitor when chosen day on above calendar has 0-2 things happening.
Screenshot

I fixed this years ago in my own style just putting the min-height to '0px' of course.
I'm guessing this gap happens to everyone and of course it could be fixed individually in the SkinPlugin, but I was wondering if this could be done 'built-in' the MyMonitor instead and working directly when module is enabled?

That would save everyone the annoyance of having the 'gap' in the first place :)

@unnecessarydave
Copy link
Collaborator

I don't see why not. There is code to allow each module to add its own CSS, and I assume it is only injected when the module is enabled.

That gap has always bugged me too, and I've never understood why they set min-height to a seemingly arbitrary value. Perhaps it served some purpose in the past.

@unnecessarydave
Copy link
Collaborator

For future reference: MyMonitor should switch; from using a URL to add matches; to using CHPP live.xml?actionType=addMatch.

Using /Club/Matches/Live.aspx?matchID=[match1Id],[match2Id],...&actionType=addMatch&SourceSystem=[sourceSystem] has a couple of issues:

  • Matches of a differing sourceType cannot be added in a single request.
  • Refreshing the opened Live page will re-add any matches from the URL that were removed from Live.

And in general CHPP is just the correct way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants