Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get the metrics info by metrics_prometheus crate #688

Closed
Ma1oneZhang opened this issue Sep 6, 2024 · 4 comments
Closed

Can't get the metrics info by metrics_prometheus crate #688

Ma1oneZhang opened this issue Sep 6, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Ma1oneZhang
Copy link

I used to register the foyer crate metrics into my own prometheus registry like belowing code

metrics_prometheus::install();
// do something

But after the version update(0.10.1 => 0.11.1), i can't use it to access th metrics in foyer crate anymore.

How can i solve the problem?

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 6, 2024

Hi @Ma1oneZhang . Thank you for reporting.

Would you mind provide more information about the environment? Like metrics-prometheus version you are using, are you using non-default metrics registry, etc.

If you are using non-default registry, you can refer to the docs of metrics-prometheus, or sample usage in RisingWave.

https://github.com/risingwavelabs/risingwave/blob/71753f11223cd0b4d67ba6baf7ac636fa246e7fc/src/storage/src/store_impl.rs#L632-L634

@MrCroxx MrCroxx self-assigned this Sep 6, 2024
@MrCroxx MrCroxx added the bug Something isn't working label Sep 6, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Sep 6, 2024
@Ma1oneZhang
Copy link
Author

Ma1oneZhang commented Sep 6, 2024

I'm using default registry, i just repair some update changes and the metrics not working anymore.

BTW, the version of metrics-prometheus is 0.7.0, the foyer is the lastest version 0.11.1 with mtrace feature.

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 6, 2024

And the version of metrics and metrics-prometheus?

FYI: instrumentisto/metrics-prometheus-rs#10

@MrCroxx
Copy link
Collaborator

MrCroxx commented Sep 10, 2024

Verified with @Ma1oneZhang offline. This is caused by they are using wrong registry. Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants