Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of core library functions #426

Closed
tcompa opened this issue Jun 13, 2023 · 3 comments · Fixed by #459
Closed

Improve coverage of core library functions #426

tcompa opened this issue Jun 13, 2023 · 3 comments · Fixed by #459
Labels
july2023 Maintenance work planned for July 2023 maintenance

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jun 13, 2023

See https://htmlpreview.github.io/?https://github.com/fractal-analytics-platform/fractal-tasks-core/blob/python-coverage-comment-action-data/htmlcov/index.html

One that obviously requires some extra care is fractal_tasks_core/lib_masked_loading.py

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 14, 2023

@tcompa tcompa added the july2023 Maintenance work planned for July 2023 label Jul 17, 2023
@tcompa tcompa linked a pull request Jul 17, 2023 that will close this issue
@tcompa
Copy link
Collaborator Author

tcompa commented Jul 18, 2023

This is now better as of #459. but there is still room for further improvements.

@tcompa tcompa reopened this Jul 18, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Jul 19, 2023

As of #459, #467 and #468, the core-library coverage increased significantly:

Module statements missing excluded branches partial coverage
lib_channels.py 106 1 0 58 1 99%
lib_glob.py 19 0 0 8 0 100%
lib_input_models.py 56 0 0 12 0 100%
lib_masked_loading.py 61 9 0 16 6 81%
lib_metadata_parsing.py 98 7 0 30 8 88%
lib_parse_filename_metadata.py 33 1 0 12 1 96%
lib_pyramid_creation.py 27 0 0 10 0 100%
lib_read_fractal_metadata.py 34 0 0 14 0 100%
lib_regions_of_interest.py 135 3 0 42 3 97%
lib_ROI_overlaps.py 158 5 0 62 6 95%
lib_upscale_array.py 73 7 0 48 6 88%
lib_zattrs_utils.py 49 2 0 28 2 95%

Closing for now.

@tcompa tcompa closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
july2023 Maintenance work planned for July 2023 maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant