Enable to import vac as CSV #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
3a20f65 to
c06cbd7
Compare
Robbert
requested changes
Jan 13, 2025
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
c06cbd7 to
434a366
Compare
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
5959439 to
cd0dfb4
Compare
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
cd0dfb4 to
033875f
Compare
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
033875f to
09a22e7
Compare
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
09a22e7 to
b51909e
Compare
Robbert
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Laatste puntje: het zou netjes zijn om een eigen openapi.yaml te hebben en te publiceren voor deze nieuwe REST API. Zie API-51
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
b51909e to
399bb87
Compare
AliKdhim87
force-pushed
the
enable-to-import-vac-as-csv
branch
from
399bb87 to
baac064
Compare
Robbert
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strapi v4 does not natively support bulk creation endpoints, which can make handling large numbers of entries inefficient. While a custom controller could be implemented to handle multiple entries in a single request, this would require backend adjustments and might not be worth the effort, as this feature is only needed once. Additionally, bulk creation support may be available in Strapi v5, making this solution more temporary.
To address this, I implemented a loop that processes each entry individually while controlling concurrency with p-limit. This ensures no more than 5 requests are sent at once, preventing server overload and improving performance. By using p-limit, the system remains stable and responsive, even when processing multiple entries concurrently.
issue