Merge pull request #43188 from rtdany10/gp_so_issue

fix: invalid gp calculation
frappe · Sep 17, 2024 · e29e1e4 · e29e1e4
2 parents 891d383 + c798512
commit e29e1e4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py
@@ -637,7 +637,7 @@ def set_gross_profit(self):
 		if self.doctype in ["Sales Order", "Quotation"]:
 			for item in self.items:
 				item.gross_profit = flt(
-					((item.base_rate - flt(item.valuation_rate)) * item.stock_qty),
+					((flt(item.stock_uom_rate) - flt(item.valuation_rate)) * item.stock_qty),
 					self.precision("amount", item),
 				)