fix: deduct advances adjusted for threshold check for tcs #43271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ljain112
force-pushed
the
fix-tcs
branch
2 times, most recently
from
cb0f389
to
4f106e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCS is deducting twice in sales invoice if advance payment is received from a customer and then the sales invoice is booked separately.
The typical use case is
Sales Invoice - 400
Advance Payment Entry = 300
Advance Payment Entry Adjusted - 100
Threshhold - 500
Before
Chargeble Amount = 400+300 -500 = 200
After
Chargeble Amount = 400+300-100-500 = 100
closes: #42001
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/20142