Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact photo update #1354

Closed
2 tasks done
michellealva opened this issue Jul 26, 2023 · 2 comments · Fixed by #1355
Closed
2 tasks done

Contact photo update #1354

michellealva opened this issue Jul 26, 2023 · 2 comments · Fixed by #1355
Labels
UX

Comments

@michellealva
Copy link
Contributor

michellealva commented Jul 26, 2023 •
edited
Loading

  • Do not show "Change Photo" when there is no photo updated. Show upload photo instead?
  • Do not show "Remove" when there is no photo updated. Only show this if there is a photo is updated.
image
ssiyad added a commit to ssiyad/helpdesk that referenced this issue Jul 26, 2023
@ssiyad
fix(ux): contact picture buttons and labels
14a635b 
frappe#1354
- Do not show "Change Photo" when there is no photo updated
- Do not show "Remove" when there is no photo updated. Only show this if there is a photo is updated
@ssiyad ssiyad mentioned this issue Jul 26, 2023
Merged
ssiyad added a commit that referenced this issue Jul 26, 2023
@ssiyad
fix(ux): contact picture buttons and labels (#1355)
d84636c 
#1354
- Do not show "Change Photo" when there is no photo updated
- Do not show "Remove" when there is no photo updated. Only show this if there is a photo is updated
@michellealva
Copy link
Contributor Author

@ssiyad please fix the same for customer as well.

image

@michellealva michellealva reopened this Jul 26, 2023
@michellealva
Copy link
Contributor Author

michellealva commented Jul 26, 2023 •
edited
Loading

fixed via #1360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ux): contact picture buttons and labels ssiyad/helpdesk
1 participant
@michellealva