fix: don't access db unnecessarily #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport version-15-hotfix |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
(cherry picked from commit 63f34cf)
ruchamahabal
added a commit
that referenced
this pull request
Sep 21, 2024
…2219 fix: don't access db unnecessarily (backport #2219)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
# [15.30.0](v15.29.0...v15.30.0) (2024-09-26) ### Bug Fixes * Accomodate `common_filters=None` in Bank Reco API ([7204774](7204774)) * don't access db unnecessarily ([#2219](#2219)) ([b456ee0](b456ee0)) * **Roster:** align with copy-html-entry constant ([#2216](#2216)) ([9af2255](9af2255)) * site name != host ([#2212](#2212)) ([7eb2b5b](7eb2b5b)) ### Features * add error message for annual allocation exceeded ([f28635f](f28635f)) * **Earned Leave:** allocate leaves manually ([9797033](9797033))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to frappe/erpnext#43301
This just created a major outage in producton (no payments could be processed by Guest in a restricted whitelisted permission scope - see Frappe PR linked in that ERPNext PR for details)