-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cases when LibreOffice hangs #878
Comments
Re-introducing timeouts for the whole document is a solution I'd personally like to avoid. They have bitten us a lot in the past (#749), they are arbitrary (documents with many pages lead to very large timeout times), and we have recently decided to ditch them altogether (#687). What makes more sense to me is the following:
Some extra benefits of this approach:
|
Some of the files in our large test set can make LibreOffice hang. We do not have a proper solution for this yet, but we can at least make the tests timeout quickly, so that they can finish at some point. Refs #878
Some of the files in our large test set can make LibreOffice hang. We do not have a proper solution for this yet, but we can at least make the tests timeout quickly, so that they can finish at some point. Refs #878
(Leaving unmilestoned for now given lower potential impact) |
Some of the files in our large test set can make LibreOffice hang. We do not have a proper solution for this yet, but we can at least make the tests timeout quickly, so that they can finish at some point. Refs #878
When running Dangerzone against our large test set, we found that some files (e.g.,
fdo78883.docx
andofz21168-1.doc
) make LibreOffice 7.6 hang.We opened a bug report for these files, but until the underlying issue is solved, we need a way to detect such hangs, and stop the conversion.
The text was updated successfully, but these errors were encountered: