Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML step when generating rulesets #154

Open
legoktm opened this issue Jan 19, 2024 · 0 comments
Open

Remove XML step when generating rulesets #154

legoktm opened this issue Jan 19, 2024 · 0 comments

Comments

@legoktm
Copy link
Member

legoktm commented Jan 19, 2024

The current workflow is:

  • pull data from the SD directory API (JSON format) plus onboarded.txt (CSV)
  • manually write an XML file for each instance (committed)
  • parse the XML and concatenate all of them into a JSON blob (gitignored)
  • compress the JSON and sign it (committed)

I think it would be easier to just write JSON files and lose the XML indirection. It made sense when we were still using HTTPSE's tooling, but that's no longer the case. We should just commit a pretty-printed JSON blob (either one per instance, or just one giant-but-not-really for everything) and the compressed + signed versions. That would also probably fix issues like #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant