Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use organization_url to on-board organizations #48

Open
eloquence opened this issue Apr 26, 2021 · 2 comments
Open

Use organization_url to on-board organizations #48

eloquence opened this issue Apr 26, 2021 · 2 comments

Comments

@eloquence
Copy link
Member

We recently added support for tracking organization URLs to the SecureDrop directory, and populated it with their current URLs. See freedomofpress/securedrop.org#675 for background. This allows us to onboard organizations using their main site URL, instead of the landing page URL, which is more likely to change.

We should switch sddir.py to parse the organization URL, which will likely require updating some existing records.

@eloquence eloquence changed the title Use organization_url to on-board organizations Use organization_url to on-board organizations Apr 26, 2021
@conorsch
Copy link
Contributor

conorsch commented Feb 7, 2022

This would indeed be a lot saner. It's a simple change, but right now two orgs are missing the required organization_url field:

curl -s https://securedrop.org/api/v1/directory/ | jq '.[] | select(.organization_url == "").title' -r
HuffPost
Forbidden Stories

Simple enough to add those and proceed, which I'll do after knocking out the outstanding onion name requests (#80 & #81). We should consider setting those fields as required on the model, but for now we'll just consider them required for onboarding to onion names.

@zenmonkeykstop
Copy link
Contributor

There are now 3 orgs missing the organization.url field (add the Markup to the list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants