Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust some of the other components like ManagedByToolbar or ManagedByAddModal to do a single concern #100

Open
carma12 opened this issue May 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@carma12
Copy link
Collaborator

carma12 commented May 4, 2023

The interface of the ManagedByAddModal is kinda hard to understand when we don't know the implementation.

E.g. I'd expect to have something like:

<AssociationAddModal
   chosenEntries={managedByHosts}, // containing list of { key: host.uid, value: hostName }
   availableEntriesLoader={functionToProvidePromiseOfListOfAvailableHosts} // promise would return same data structure as ^^
   onSelectionChange={callback(selectedEntries)}
   title="string"     
/>

This would be usable for all the simple associations.

Originally posted by @pvoborni in #67 (comment)

@carma12 carma12 added the enhancement New feature or request label May 4, 2023
Copy link

This issue has not received any attention in 120 days.

@github-actions github-actions bot added the stale This PR/issue is stale and will be closed label Dec 11, 2023
@carma12 carma12 removed the stale This PR/issue is stale and will be closed label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant