Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal | Migrating to Javascript default parameters #509

Open
lloydaf opened this issue Jan 17, 2025 · 0 comments
Open

Modal | Migrating to Javascript default parameters #509

lloydaf opened this issue Jan 17, 2025 · 0 comments

Comments

@lloydaf
Copy link
Contributor

lloydaf commented Jan 17, 2025

  • @freenow/wave version: 2.21.2

Relevant code

expect(consoleErrorSpy).not.toHaveBeenCalled()

What was expected to happen?

When running the tests, wave's Modal is throwing the following deprecation error messages (check screenshot) that causes the tests to fail.

Image

Reproduction

Not sure how to reproduce this, this was seen from a vitest test environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lloydaf