-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove email from json dataset #7
Comments
This one's a bit tricky. The server is exposing its CouchDB completely. So there's no way to hide an email address from the database. The only way is to not send it to the database in the first place. The email address is added on each device via https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/luasrc/owm.lua#L261. Maybe we should make this configurable? Since we'll make the switch to libremap soon, we can change it there directly: https://github.com/libremap/libremap-agent-openwrt. |
I think the default should be to not submit an email address. If a user wants the address to show up, she/he can configure the submit agent to do so. |
@andrenarchy Thanks a lot! :) |
The email address is added here. Thus, the address is read from We plan to make it configurable in the future. |
By the way: feel free to file a PR for luci-app-owm! 😄 However, we'll switch to libremap soon, so it may be more efficient to implement it there directly. |
it is possible to remove the email address from the json data after you clicked "Full JSON Dataset"? I know it's not full then anymore but for privacy reason we could think about it after there is a mail form (see #6)
The text was updated successfully, but these errors were encountered: