Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_js 2.0 coming soon... #14

Closed
Tracked by #1671
gregmagolan opened this issue May 7, 2024 · 2 comments · Fixed by #16
Closed
Tracked by #1671

rules_js 2.0 coming soon... #14

gregmagolan opened this issue May 7, 2024 · 2 comments · Fixed by #16
Labels
Enhancement New feature or request

Comments

@gregmagolan
Copy link

gregmagolan commented May 7, 2024

Hey @hjellek, just noticed this new rule set from the BCR PR this morning. Its great to see the community building out support for more node tools on top of rules_js.

Just a heads up that we're currently working on releasing rules_js 2.0 which has breaking changes to the internal API that rules_jest is using. Here is what the change looks like in rules_jest: aspect-build/rules_jest#269.

Here is a tracking issue for the release work: aspect-build/rules_js#1671. We're probably a few weeks away from releasing with a few more things we'd like to get in.

In any case, just wanted to give you a heads up incase you wanted to wait until we have a rules_js 2.0 release out before you launch rules_vitest.

@gregmagolan gregmagolan changed the title rules_2.0 coming soon... rules_js 2.0 coming soon... May 7, 2024
@hjellek
Copy link
Contributor

hjellek commented May 8, 2024

Hi @gregmagolan, thanks for reaching out and thanks for all your work.

I noticed that the pre-submit actions in BCR failed with an error anyway, so it sounds like a good idea to wait for rules_js 2.0.

Thanks for the heads up, I will submit a new PR once we have upgraded to rules_js 2.0.

@hjellek hjellek added Enhancement New feature or request and removed untriaged labels May 8, 2024
@alexeagle
Copy link

Note, the first Release Candidate of rules_js 2.0 is now published :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants