Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of optional metaText details for Feat/select-options #936

Open
wants to merge 14 commits into
base: next
Choose a base branch
from

Conversation

harshith-venkatesh-freshworks
Copy link
Contributor

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

There is an introduction of new variant in previous build where we had introduced new set of data field called metaText.
Here, in case of select-options as well, we are adding the support conditionally to ensure the metaText details if present is made available in the fw-select which is used to create dynamically in fw-form.

Screenshot 2024-09-20 at 2 35 35 PM

@harshith-venkatesh-freshworks
Copy link
Contributor Author

Screenshot 2024-09-23 at 10 31 31 AM

Hi @rihansiddhi @arvindanta , Reverting the above changes, I am still observing the same set of errors here.
How should we be proceeding with the issue?

@harshith-venkatesh-freshworks
Copy link
Contributor Author

Screenshot 2024-09-23 at 5 56 30 PM

Addition of icon alignment for conversation variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant