Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending support to custom modules #41

Open
vkothapally opened this issue Mar 17, 2021 · 3 comments
Open

Extending support to custom modules #41

vkothapally opened this issue Mar 17, 2021 · 3 comments
Assignees
Labels
module: modules Related to modules type: improvement New feature or request
Milestone

Comments

@vkothapally
Copy link

🚀 Compatibility with Complex Modules

Thank you for the great repo. Can you please let me know if you would be willing to extend this to be compatible with complex convolution modules too? (For instance, you can look at cplxmodule or speechBrain). This will really help is comparing various models from architectural details to memory usage standpoint.

@vkothapally vkothapally added the type: improvement New feature or request label Mar 17, 2021
@vkothapally vkothapally changed the title New Feature request Feature request Mar 17, 2021
@frgfm frgfm changed the title Feature request Extending support of custom modules Mar 17, 2021
@frgfm frgfm changed the title Extending support of custom modules Extending support to custom modules Mar 17, 2021
@frgfm frgfm added this to the 0.2.0 milestone Mar 17, 2021
@frgfm frgfm added the module: modules Related to modules label Mar 17, 2021
@frgfm
Copy link
Owner

frgfm commented Mar 17, 2021

Hi @vkothapally,

Thanks for asking! There are two answers I can give you:

  1. As of now, this library is designed to detect inherited modules (from PyTorch parent classes) and leverages this to cover most of model's components. Using this design, it wouldn't be possible to add support for custom modules apart from manually adding dependencies to all libraries that define custom modules.

  2. That being said, I am considering completely changing the library for v0.2.0 by using ONNX export. It would limit support of ONNX exportable modules but I would be able to produce the same information without manually writing the computation of FLOPS, etc.

So in the short term, apart from if you have a good PR in mind, I'm afraid I won't add support to this before v0.2.0 :/

@ratom
Copy link

ratom commented May 24, 2023

I tried to calculate the receptive fields for VGG, and ResNet. It works for VGG, but not for resnet. Can you help me.

@frgfm
Copy link
Owner

frgfm commented May 28, 2023

Hey @ratom,

As of now, the receptive field feature works on "highway nets" meaning that skip connections cannot be handled appropriately!
I'll try to see how I can address this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: modules Related to modules type: improvement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants