Skip to content

Add Sponsor Variant#44

Merged
mathiash98 merged 3 commits intomainfrom
mathias/sponsor-varian
Sep 20, 2024
Merged

Add Sponsor Variant#44
mathiash98 merged 3 commits intomainfrom
mathias/sponsor-varian

Conversation

@mathiash98
Copy link
Contributor

@mathiash98 mathiash98 self-assigned this Sep 18, 2024
@KWaloen
Copy link
Contributor

KWaloen commented Sep 18, 2024

Variant is a bit hard to read no? Would it help to put a white outline on the logo as with Kantega?

@mathiash98
Copy link
Contributor Author

Variant is a bit hard to read no? Would it help to put a white outline on the logo as with Kantega?

Yep agree, seems like we should have a white background on the full sponsors-container area. And switch the NAV logo to the red one

@timharek
Copy link
Contributor

What if the sponsors-section had a white background? That would solve the visibility issue for all of the logos.

@mathiash98
Copy link
Contributor Author

Changed background to the white color we use on text

image

Copy link
Contributor

@timharek timharek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@mathiash98 mathiash98 merged commit 21c18b0 into main Sep 20, 2024
@mathiash98 mathiash98 deleted the mathias/sponsor-varian branch September 20, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants