Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: explain group vs. layer #334

Open
pgilfernandez opened this issue Nov 19, 2024 · 9 comments
Open

Docs: explain group vs. layer #334

pgilfernandez opened this issue Nov 19, 2024 · 9 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@pgilfernandez
Copy link

It might be not a bug as groups and layers are not the same but as groups have the opacity parameter exposed it would have to work...

group-layer

example project: opacity.friction.zip

So, the opacity parameter doesn't work for groups, it's not something important but trying to follow a good UX, it would suggest to:

  • hide the opacity parameter in Groups
  • make it works

Thanks!

@rodlie
Copy link
Member

rodlie commented Nov 19, 2024

Groups are not layers.

Opacity is part of transform, it does not know what the parent box/item/whatever is.

@pgilfernandez
Copy link
Author

Groups are not layers.

Opacity is part of transform, it does not know what the parent box/item/whatever is.

I understand what you mean, but if, under a group, that property doesn't make sense (or does nothing), it should be hidden (for instance) or it could confuse users, don't you think?

BTW, this is not an important thing, but when you decide to fine polish Friction, this could be addressed...

@rodlie
Copy link
Member

rodlie commented Nov 19, 2024

Yeah... but this is also a slippery slope, the more complexity added the worse things get over time.

If the code change is trivial sure.

@rodlie
Copy link
Member

rodlie commented Nov 19, 2024

btw, it does serve a purpose as SVG supports opacity in groups.

@pgilfernandez
Copy link
Author

pgilfernandez commented Nov 19, 2024

Yeah... but this is also a slippery slope, the more complexity added the worse things get over time.

If the code change is trivial sure.

Yes, I agree with that, hehehe

btw, it does serve a purpose as SVG supports opacity in groups.

Once again you are right, but then, why not to add opacity support for groups inside Friction?

@rodlie
Copy link
Member

rodlie commented Nov 19, 2024

why not to add opacity support for groups inside Friction?

Because opacity is a compositing operation.

in Friction a group can only affect transforms, not compositing operations, for that you need a layer.

@pgilfernandez
Copy link
Author

I understand... well, if you fully feel like this is not an issue then close it ;)

@rodlie
Copy link
Member

rodlie commented Nov 19, 2024

The best option IMHO is documentation, a dedicated "Groups vs. Layers" section probably.

@pgilfernandez
Copy link
Author

The best option IMHO is documentation, a dedicated "Groups vs. Layers" section probably.

Hahaha, once again you are right, this is very important. I hope to help in this regard =)

@rodlie rodlie added the documentation Improvements or additions to documentation label Dec 2, 2024
@rodlie rodlie changed the title Group opacity not working Docs: explain group vs. layer Dec 2, 2024
@rodlie rodlie added this to the 1.0.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants