Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATREQ] Add a toggle to ignore lectures when considering free days #36

Open
frizensami opened this issue Jun 24, 2021 · 6 comments
Open
Assignees
Labels
enhancement New feature or request OPT

Comments

@frizensami
Copy link
Owner

frizensami commented Jun 24, 2021

Is your feature request related to a problem? Please describe.
Some people consider days with lectures "Free days" since they can be webcast, or they'll just read the notes. That makes the current free days algo too restrictive.

Describe the solution you'd like
Add toggle that ignores anything coded with LEC (actually, idk if it's just LEC, so this might become very complicated!) from the free day calculation

@frizensami frizensami added enhancement New feature or request OPT labels Jun 24, 2021
@frizensami frizensami removed the enhancement New feature or request label Jun 24, 2021
@vegetablestabber
Copy link

Hi there, Sriram!

  1. Do you think you could also include lectures with venues such as 'E-learning'? Or if venue is an issue, I can imagine a toggle for lectures named 'Optional to be in-person', which is toggled off by default.
  2. Your free days filter is great, but maybe another constraint could be 'Optional in-person classes to be ignored for free days' so users have the option to toggle it on and off. Maybe it doesn't have to be a full-on constraint, so it can be another toggle like the 'Make the timetable as compact as possible...' toggle? Not sure if that's a constraint because of how it looks visually from the other constraints.

Also, I really find this app really helpful in course planning, so thanks for this god-tier project. 🫡

@frizensami
Copy link
Owner Author

Hey, good point! When I did this I hadn't considered E-lectures. Could you give me an example timetable (e.g., some modules with E-learning that might conflict with other slots) that I can test with?

Also i'm glad to hear you're using it!

@frizensami
Copy link
Owner Author

I guess also I should just enable the toggle so that even if the lecture is marked as physical, that you can choose to webcast it etc

@frizensami frizensami added the enhancement New feature or request label Jul 26, 2024
@frizensami frizensami self-assigned this Jul 26, 2024
@frizensami
Copy link
Owner Author

Also, I'm going to be busy for the next few weeks with my thesis, so if you have a chance to submit a PR, that's also very welcome. If not i'll be making it a high priority fix :)

@vegetablestabber
Copy link

Hey, good point! When I did this I hadn't considered E-lectures. Could you give me an example timetable (e.g., some modules with E-learning that might conflict with other slots) that I can test with?

Here's an example. I'm not following this timetable but I hope it suits your purposes.

Also, I'm going to be busy for the next few weeks with my thesis, so if you have a chance to submit a PR, that's also very welcome. If not i'll be making it a high priority fix :)

I'd love to contribute but I'm not sure I can at this juncture because I'm wrapping up my internship and I have other responsibilities at school. I'll definitely look through when I get the time though, thanks!

@frizensami
Copy link
Owner Author

Here's an example. I'm not following this timetable but I hope it suits your purposes.

Thank you! I'll give it a shot once i have some time. Again, glad that this was helpful in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OPT
Projects
None yet
Development

No branches or pull requests

2 participants