Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

コマンドやスナップショット用のnewtype型を導入する #4

Open
sile opened this issue Oct 12, 2018 · 0 comments
Open

Comments

@sile
Copy link
Member

sile commented Oct 12, 2018

現在、コマンドやスナップショットはどちらもVec<u8>として扱われているが、Command(Vec<u8>)Snapshot(Vec<u8>)という型を用意した方が、実装ミスの可能性が減って良いかもしれない。
仮に導入するにしても「内部に閉じた型にする」or「外部インタフェースにまで含める」のどちらにするかは要検討。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant