Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests pass on all platforms #3

Open
jonathanong opened this issue Jun 26, 2014 · 8 comments
Open

make tests pass on all platforms #3

jonathanong opened this issue Jun 26, 2014 · 8 comments

Comments

@jonathanong
Copy link
Contributor

not working for me on os x even though the code looks correct. not sure wtf is going on...

@jonathanong
Copy link
Contributor Author

seeking @amasad's assistance :D

@amasad
Copy link

amasad commented Jun 27, 2014

why not just use sane? ;p

@jonathanong
Copy link
Contributor Author

maybe. some philosophical differences like i have no idea which directories to watch, i know exactly which files to watch, and the lists of files changes. not sure how to do this with sane without watching every freaking thing in cwd haha

@amasad
Copy link

amasad commented Jun 27, 2014

you can call sane per file easily

@amasad
Copy link

amasad commented Jun 27, 2014

anyways, I can help, but let me know what specifically is not working

@jonathanong
Copy link
Contributor Author

you can call sane per file easily

what do you mean? if i could do sane([filenames]) then sane().add(filename) and sane().remove(name) or something that would work. not sure how to do that now.

basically this: https://github.com/normalize/nlz/issues/5#issuecomment-45409151. a file is renamed to overwrite a watched file.

@amasad
Copy link

amasad commented Jun 27, 2014

watching a single file:

var watcher = sane(filename);
watcher.close();

You can write a simple layer on top to implement a nice for add and remove if you want.

basically this: normalize/nlz#5 (comment). a file is renamed to overwrite a watched file.

Actually I'm not sure if I handle this case in sane :/

@jonathanong
Copy link
Contributor Author

\o/

you might not hit this issue if you're already watching the file that overwrites the other file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants