From 1f69a0b129455ed712b1513ebf362c1c3be17b2f Mon Sep 17 00:00:00 2001
From: Matthew Iannucci <matthew@earthmover.io>
Date: Thu, 10 Oct 2024 13:48:28 -0400
Subject: [PATCH] Save progress

---
 kerchunk/netCDF3.py           | 13 ++++++++++---
 kerchunk/tests/test_hdf.py    |  2 +-
 kerchunk/tests/test_netcdf.py | 20 ++++++++++++++++++--
 3 files changed, 29 insertions(+), 6 deletions(-)

diff --git a/kerchunk/netCDF3.py b/kerchunk/netCDF3.py
index d44fc808..b9d47063 100644
--- a/kerchunk/netCDF3.py
+++ b/kerchunk/netCDF3.py
@@ -1,4 +1,5 @@
 from functools import reduce
+from packaging.version import Version
 from operator import mul
 
 import numpy as np
@@ -167,7 +168,13 @@ def translate(self):
         import zarr
 
         out = self.out
-        z = zarr.open(out, mode="w", zarr_format=2)
+        if Version(zarr.__version__) < Version("3.0.0.a0"):
+            store = zarr.storage.KVStore(out)
+            z = zarr.group(store=store, overwrite=True)
+        else:
+            store = zarr.storage.MemoryStore(mode="a", store_dict=out)
+            z = zarr.open(store, mode="w", zarr_format=2)
+
         for dim, var in self.variables.items():
             if dim in self.chunks:
                 shape = self.chunks[dim][-1]
@@ -197,7 +204,7 @@ def translate(self):
                     dtype=var.data.dtype,
                     fill_value=fill,
                     chunks=shape,
-                    compression=None,
+                    compressor=None,
                 )
                 part = ".".join(["0"] * len(shape)) or "0"
                 k = f"{dim}/{part}"
@@ -251,7 +258,7 @@ def translate(self):
                     dtype=base,
                     fill_value=fill,
                     chunks=(1,) + dtype.shape,
-                    compression=None,
+                    compressor=None,
                 )
                 arr.attrs.update(
                     {
diff --git a/kerchunk/tests/test_hdf.py b/kerchunk/tests/test_hdf.py
index 665cd392..233a58e4 100644
--- a/kerchunk/tests/test_hdf.py
+++ b/kerchunk/tests/test_hdf.py
@@ -27,7 +27,7 @@ async def list_dir(store, path):
 def create_store(test_dict: dict, remote_options: Any = None):
     if Version(zarr.__version__) < Version("3.0.0.a0"):
         return fsspec.get_mapper(
-            "reference://", fo=test_dict, remote_protocol="s3", remote_options=so
+            "reference://", fo=test_dict, remote_protocol="s3", remote_options=remote_options
         )
     else:
         fs = fsspec.implementations.reference.ReferenceFileSystem(fo=test_dict, remote_options=remote_options)
diff --git a/kerchunk/tests/test_netcdf.py b/kerchunk/tests/test_netcdf.py
index 43b6021b..0036c0a3 100644
--- a/kerchunk/tests/test_netcdf.py
+++ b/kerchunk/tests/test_netcdf.py
@@ -1,4 +1,5 @@
 import os
+from typing import Any
 
 
 import fsspec
@@ -7,6 +8,8 @@
 import pytest
 from kerchunk import netCDF3
 
+import zarr
+
 xr = pytest.importorskip("xarray")
 
 
@@ -24,16 +27,29 @@
 )
 
 
+def create_store(test_dict: dict, remote_options: Any = None):
+    if Version(zarr.__version__) < Version("3.0.0.a0"):
+        return fsspec.get_mapper(
+            "reference://", fo=test_dict, remote_protocol="s3", remote_options=remote_options
+        )
+    else:
+        fs = fsspec.implementations.reference.ReferenceFileSystem(fo=test_dict, remote_options=remote_options)
+        return zarr.storage.RemoteStore(fs, mode="r")
+
+
 def test_one(m):
     m.pipe("data.nc3", bdata)
     h = netCDF3.netcdf_recording_file("memory://data.nc3")
     out = h.translate()
+
+    store = create_store(out, remote_options={"remote_protocol": "memory"})
+
     ds = xr.open_dataset(
-        "reference://",
+        store,
         engine="zarr",
         backend_kwargs={
             "consolidated": False,
-            "storage_options": {"fo": out, "remote_protocol": "memory"},
+            "zarr_format": "2",
         },
     )
     assert (ds.data == data).all()