From baba30b4bbe35bc095f871812e3e8b0e6d1fd5f3 Mon Sep 17 00:00:00 2001 From: fumikito Date: Wed, 28 Aug 2024 17:04:12 +0900 Subject: [PATCH] #132 Fix lint and phpstan. --- .github/workflows/wordpress.yml | 2 +- app/Gianism/Pattern/Singleton.php | 2 +- composer.json | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/wordpress.yml b/.github/workflows/wordpress.yml index be9040e..1ace947 100644 --- a/.github/workflows/wordpress.yml +++ b/.github/workflows/wordpress.yml @@ -93,7 +93,7 @@ jobs: run: composer install --prefer-dist --no-progress - name: Run PHP Stan - run: composer analyze -- --error-format=github + run: composer analyze:github assets: name: Assets Test diff --git a/app/Gianism/Pattern/Singleton.php b/app/Gianism/Pattern/Singleton.php index cde842a..34022f1 100644 --- a/app/Gianism/Pattern/Singleton.php +++ b/app/Gianism/Pattern/Singleton.php @@ -22,9 +22,9 @@ abstract class Singleton { * Constructor * * @param array $argument + * @phpstan-ignore constructor.unusedParameter */ protected function __construct( array $argument = [] ) { - // @phpstan-ignore constructor.unusedParameter // Override something. } diff --git a/composer.json b/composer.json index d40dd5b..eebf714 100644 --- a/composer.json +++ b/composer.json @@ -14,7 +14,8 @@ "lint": "phpcs --standard=phpcs.ruleset.xml .", "fix": "phpcbf --standard=phpcs.ruleset.xml .", "test": "phpunit", - "analyze": "phpstan analyze --memory-limit=2G" + "analyze": "phpstan analyze --memory-limit=2G", + "analyze:github": "phpstan analyze --memory-limit=2G --error-format=github" }, "require": { "php": ">=7.2",