Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sources of inconsistent naming #4

Open
adjavon opened this issue Apr 4, 2024 · 0 comments
Open

Reduce sources of inconsistent naming #4

adjavon opened this issue Apr 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@adjavon
Copy link
Contributor

adjavon commented Apr 4, 2024

In the current tutorials and set ups for doing attribution and evaluation, we name things via proxy by using dictionaries like:

attributions = {"discriminative_dl" : DDeepLift(classifier)}

Since these names are used later to name dictionaries/processes, it would be nice if we directly used the name of the attribution we used. I'm envisioning something like:

# The version in a config file
attributions = ["DDeepLift", "DIntegratedGradients"]
# The version in a script
attributions = [DDeepLift, DIntegratedGradients]

We could both get attributions by name, or get a name from an attribution object. This could be extended to things like the processor used, etc. This could make naming conventions more consistent across runs.

@adjavon adjavon self-assigned this Apr 4, 2024
@adjavon adjavon changed the title Reduce unnecessary naming Reduce sources of inconsistent naming Apr 5, 2024
@adjavon adjavon added the enhancement New feature or request label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant