Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PyGLTFLib an optional dependency #873

Open
guaje opened this issue Mar 29, 2024 · 6 comments · May be fixed by #875
Open

Make PyGLTFLib an optional dependency #873

guaje opened this issue Mar 29, 2024 · 6 comments · May be fixed by #875
Labels
good first issue Good for newcomers

Comments

@guaje
Copy link
Contributor

guaje commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
PyGLTFLib usage in the codebase is lower than some optional dependencies, such as DIPY.

Describe the solution you'd like
Make PyGLTFLib an optional dependency.

@noobyco
Copy link

noobyco commented Mar 30, 2024

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

noobyco added a commit to noobyco/fury that referenced this issue Mar 30, 2024
close fury-gl#873
Make PyGLTFLib an optional dependency
@noobyco noobyco linked a pull request Mar 30, 2024 that will close this issue
@guaje
Copy link
Contributor Author

guaje commented Mar 30, 2024

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

@noobyco
Copy link

noobyco commented Apr 2, 2024

moving PyGLTFLib from requirements/default to requirements/optional shuold do the thing. I'm on it.

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

Yeah sure!

@robinroy03
Copy link
Member

@noobyco, you still working on this issue? I'll be happy to help.

@noobyco
Copy link

noobyco commented Apr 18, 2024

@noobyco, you still working on this issue? I'll be happy to help.

I have created a PR #875 but I do need to check one thing mentioned below. Yup, we can work together if you want just hit me on Twitter https://twitter.com/noobyco :)

You also need to look for its usage in the codebase and ensure it doesn't throw errors when pyGLTFlib is not installed in the user's environment.

@janhavi-naik14
Copy link

1)Update dependency management: Modify requirements.txt, create requirements-optional.txt, and update setup.py.
2)Modify the codebase: Use try...except for importing PyGLTFLib and conditionally handle its functionality.
3)Update documentation: Inform users about the optional dependency and how to install it.
4)Test the changes: Verify that the application works with and without the optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants