-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsoid actor implemented with SDF #791
Conversation
Hi @guaje, I see that you requested a review from all but I see that this PR is a draft with WIP tag. Is this PR ready for review? What is the status ? @tvcastillod, can you answer also ? |
@skoudoro Not yet. I was waiting for today's meeting to know how to proceed with this PR, I received some comments that I will address soon, and when ready I will change the status and request the review again. |
Thank you for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tvcastillod,
Here is an initial review. I will try a bit later your PR
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 84.41% 84.33% -0.09%
==========================================
Files 43 44 +1
Lines 10166 10356 +190
Branches 1381 1410 +29
==========================================
+ Hits 8582 8734 +152
- Misses 1227 1252 +25
- Partials 357 370 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @tvcastillod, Looks good to me.
I have few questions below to clarify or correct and then I think this PR will be ready to be merged.
@JoaoDell, Can you look and review the shader part. @ganimtron-10, can you look and review the python part. Both, please, let @tvcastillod knows if you have any questions or if you see something. After that, we can go ahead and merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished reviewing mainly the shader part. The tests worked and sucessfully rendered the ellipsoids, so it is working. I just got some questions to better understand some choices, but everything seems fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tvcastillod,
I had the few below comments. Please them out then it would be ready to go.
@skoudoro I did all the requested changes, I think now it is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work @tvcastillod.
Thank you for the review @JoaoDell, @ganimtron-10 and @guaje. It is good to have other pair of eye
merging
Hi, this PR aims to create a new ellipsoid actor defined with SDF and raymarching. The goal is to make an implementation that allows displaying a large amount of data, with good visual quality, and without compromising performance. I'm still working on improvements and ways to test the implementation.