-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/compatible software #812
Feature/compatible software #812
Conversation
@ganimtron-10 @tvcastillod @JoaoDell |
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
===========================================
+ Coverage 50.47% 84.43% +33.96%
===========================================
Files 126 43 -83
Lines 28299 10274 -18025
Branches 3034 1393 -1641
===========================================
- Hits 14284 8675 -5609
+ Misses 13536 1239 -12297
+ Partials 479 360 -119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mk996 ,
Thanks for doing this, LGTM.
The components are responsive too for all screen sizes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mk996, I think that's a nice addition, overall looks great. I just have one minor comment below.
Hi @tvcastillod, I have resolved the comment can you please review this again? I have made 50px on both ends as it was the standard size used around the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the review @tvcastillod and @ganimtron-10 .
It looks good to me. Thank you for this work. Merging
PR Details: