fix paladin auras

- When training a new aura rank, it totally replaces the old spell

Author: fusionpit

.luacheckrc

@@ -36,6 +36,8 @@ read_globals = {
     "FONT_COLOR_CODE_CLOSE",
     "HIGHLIGHT_FONT_COLOR_CODE",
     "PARENS_TEMPLATE",
-    "MAX_SKILLLINE_TABS"
+    "MAX_SKILLLINE_TABS",
+
+    "HookCTPUpdate"
 }
 globals = {"ClassTrainerPlusDBPC", "CTP_UpdateService", "WhatsTrainingFrame"}

Classes/Paladin.lua

@@ -1,5 +1,34 @@
 local _, wt = ...
 if (wt.currentClass ~= "PALADIN") then return end
+
+-- Paladin Auras are special in that you never have multiple ranks in the spellbook, only the latest one
+-- Even so, IsSpellKnown will only return true for your current rank
+
+-- These tables are ordered by rank
+local devotionAura = {465, 10290, 643, 10291, 1032, 10292, 10293}
+local retAura = {7294, 10298, 10299, 10300, 10301}
+local fireResAura = {19891, 19899, 19900}
+local frostResAura = {19888, 19897, 19898}
+local shadowResAura = {19876, 19895, 19896}
+
+local auraMap = {}
+for _, auras in ipairs({devotionAura, retAura, fireResAura, frostResAura, shadowResAura}) do
+	for _, auraId in ipairs(auras) do
+		auraMap[auraId] = auras
+	end
+end
+function wt.IsPreviouslyLearnedAura(spellId)
+	print(spellId)
+	if (not auraMap[spellId]) then return false end
+	local spellIndex, knownIndex = 0, 0
+	for i, otherId in ipairs(auraMap[spellId]) do
+		if (otherId == spellId) then spellIndex = i end
+		if (IsSpellKnown(otherId)) then knownIndex = i end
+	end
+	print(spellId, spellIndex, knownIndex)
+	return spellIndex <= knownIndex
+end
+
 wt.SpellsByLevel = {
 	[1] = {{id = 465, cost = 10}},
 	[4] = {{id = 19740, cost = 100}, {id = 20271, cost = 100}},

WhatsTraining.lua

@@ -165,6 +165,9 @@ local function rebuildSpells(playerLevel, isLevelUpEvent)
                     categoryKey = MISSINGTALENT_KEY
                 elseif (level > playerLevel) then
                     categoryKey = level <= playerLevel + 2 and NEXTLEVEL_KEY or NOTLEVEL_KEY
+                elseif (wt.IsPreviouslyLearnedAura and wt.IsPreviouslyLearnedAura(spellInfo.id)) then
+                    -- special case for paladin auras, since new ranks totally replace old ranks
+                    categoryKey = KNOWN_KEY
                 else
                     local hasReqs = true
                     if (spell.requiredIds ~= nil) then
@@ -457,9 +460,11 @@ end
 
 local function hookCTP()
     wt.ctpDb = ClassTrainerPlusDBPC
-    HookCTPUpdate(function()
-        rebuildSpells(UnitLevel("player"))
-    end)
+    HookCTPUpdate(
+        function()
+            rebuildSpells(UnitLevel("player"))
+        end
+    )
 end
 
 if (HookCTPUpdate) then

changes.log

@@ -1,3 +1,6 @@
+* 1.2
+    - Fixed old Paladin Aura ranks being listed as "Available Now" after training a new rank
+
 * 1.0
     - Added category for spells that you can't train because you lack the necessary talent
     - Fixed some minor visual issues
@@ -13,4 +16,5 @@
 * 0.3-beta
     - Fix WoWI bug 8884
     - Won't show other faction's mage ports/teles
-    - Won't show other race's priest spells
+    - Won't show other race's priest spells
+