fix for firefox & bump to 1.3

Author: fuyufjh

.github/workflows/build.yml

@@ -36,20 +36,11 @@ jobs:
     - name: Build Chrome version
       run: ./build.sh -t chrome
 
-    - name: Build Edge version
-      run: ./build.sh -t edge
-
     - name: Upload Chrome artifact
       uses: actions/upload-artifact@v4
       with:
         name: chrome-extension
         path: arkpets-chrome-*.zip
-        
-    - name: Upload Edge artifact
-      uses: actions/upload-artifact@v4
-      with:
-        name: edge-extension
-        path: arkpets-edge-*.zip
 
     # Create GitHub Release when a tag is pushed
     - name: Create Release
@@ -58,6 +49,5 @@ jobs:
       with:
         files: |
           arkpets-chrome-*.zip
-          arkpets-edge-*.zip
       env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} 
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} 

build.sh

@@ -13,16 +13,16 @@ while [[ $# -gt 0 ]]; do
             ;;
         *)
             echo "Unknown argument: $1"
-            echo "Usage: $0 [-t|--target chrome|edge]"
+            echo "Usage: $0 [-t|--target chrome|edge|firefox]"
             exit 1
             ;;
     esac
 done
 
 # Validate target
-if [[ "$TARGET" != "chrome" && "$TARGET" != "edge" ]]; then
+if [[ "$TARGET" != "chrome" && "$TARGET" != "edge" && "$TARGET" != "firefox" ]]; then
     echo "Invalid target: $TARGET"
-    echo "Target must be either 'chrome' or 'edge'"
+    echo "Target must be either 'chrome', 'edge', or 'firefox'"
     exit 1
 fi
 
@@ -43,17 +43,36 @@ fi
 # Build the ArkPets-Web
 echo "Building ArkPets-Web..."
 pushd ArkPets-Web
+npm install
 npm run build
 popd
 
 # Build the project
 echo "Building version $MANIFEST_VERSION..."
+npm install
 npm run build
 
-# Modify manifest for Edge if needed
+# Function to perform portable sed in-place replacement
+sed_in_place() {
+    local pattern="$1"
+    local file="$2"
+    if [[ "$OSTYPE" == "darwin"* ]]; then
+        # macOS/BSD sed requires an extension argument
+        sed -i '' "$pattern" "$file"
+    else
+        # GNU sed (Linux) works without an extension
+        sed -i "$pattern" "$file"
+    fi
+}
+
+# Modify manifest for Edge/Firefox if needed
 if [ "$TARGET" = "edge" ]; then
     echo "Modifying manifest.json for Edge..."
-    sed -i 's/Chrome/Edge/g' dist/manifest.json
+    sed_in_place 's/Chrome/Edge/g' dist/manifest.json
+elif [ "$TARGET" = "firefox" ]; then
+    echo "Modifying manifest.json for Firefox..."
+    # Add-on names cannot contain the Mozilla or Firefox trademarks :D
+    sed_in_place 's/ Chrome//g' dist/manifest.json
 fi
 
 # Create zip file with version number

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "arkpets-chrome",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "private": true,
   "scripts": {
     "watch": "webpack build --watch --mode development",

package.json

@@ -2,7 +2,7 @@
   "manifest_version": 3,
   "name": "ArkPets Chrome",
   "description": "Shows Arknights characters on web pages",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "permissions": [
     "storage"
   ],
@@ -30,5 +30,11 @@
       "*.js.map"
     ],
     "matches": ["<all_urls>"]
-  }]
-} 
+  }],
+  "browser_specific_settings": {
+    "gecko": {
+      "id": "arkpets@ericfu.me",
+      "strict_min_version": "58.0"
+    }
+  }
+}