Refactor strategy service and engine initialization

Author: fvergaracl

app/api/v1/endpoints/strategy.py

@@ -20,10 +20,14 @@
 @router.get("", response_model=FindAllStrategyResult)
 @inject
 def get_strategy_list(
-    schema: FindBase = Depends(),
     service: StrategyService = Depends(Provide[Container.strategy_service]),
 ):
-    return service.get_list(schema)
+    response = service.list_all_strategies()
+    print(" ")
+    print(" ")
+    print(" ")
+    print("---------------------------------------")
+    return response
 
 
 # @router.get("{id}", response_model=FindStrategyResult)

app/engine/__init_.py

@@ -0,0 +1,30 @@
+import os
+import importlib
+from app.engine.check_base_strategy_class import check_class_methods_and_variables
+
+
+def all_engine_strategies():
+    strategies = []
+    for file in os.listdir("app/engine"):
+        if (
+                file.endswith(".py") and
+                file != "__init__.py" and
+                file != "check_base_strategy_class.py" and
+                file != "all_engine_strategies.py"):
+            strategy = file[:-3]
+            strategies.append(strategy)
+
+    # import all strategies and check if they are valid with check_base_strategy_class
+    # if not, remove them from the list
+
+    for strategy in strategies:
+        module = importlib.import_module(f"app.engine.{strategy}")
+        # get classes Name and check if it is a valid strategy
+        classes = [getattr(module, name)
+                   for name in dir(module) if name[0].isupper()]
+        for Class in classes:
+            if not check_class_methods_and_variables(Class):
+                strategies.remove(strategy)
+                break
+
+    return strategies

app/engine/__init__.py

@@ -1,15 +1,17 @@
 from app.core.exceptions import ConflictError
 from app.repository.strategy_repository import StrategyRepository
 from app.services.base_service import BaseService
-from app.engine.import_app_engine_modules import import_app_engine_modules
+from app.engine.all_engine_strategies import all_engine_strategies
+
 
 class StrategyService(BaseService):
     def __init__(self, strategy_repository: StrategyRepository):
         self.strategy_repository = strategy_repository
         super().__init__(strategy_repository)
 
-    def list_all_strategies(self, schema):
-        all_strategies = import_app_engine_modules
+    def list_all_strategies(self):
+        all_strategies = all_engine_strategies()
+        print(all_strategies)
         pass
 
     def get_strategy_by_id(self, id):