Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerize app and test dockerized service #30

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

jb-adams
Copy link
Member

No description provided.

@jb-adams jb-adams linked an issue Mar 25, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #30 (7c7ffb6) into develop (2a9a221) will decrease coverage by 6.47%.
The diff coverage is 13.33%.

@@              Coverage Diff              @@
##             develop      #30      +/-   ##
=============================================
- Coverage      77.22%   70.74%   -6.48%     
  Complexity       214      214              
=============================================
  Files             37       38       +1     
  Lines            518      540      +22     
  Branches          13       14       +1     
=============================================
- Hits             400      382      -18     
- Misses           113      155      +42     
+ Partials           5        3       -2     
Impacted Files Coverage Δ
.../ga4gh/testbed/api/app/TestbedApiSpringConfig.java 95.08% <0.00%> (-1.59%) ⬇️
...java/org/ga4gh/testbed/api/controller/Reports.java 80.00% <0.00%> (-20.00%) ⬇️
...ils/requesthandler/report/DeleteReportHandler.java 0.00% <0.00%> (ø)
...java/org/ga4gh/testbed/api/model/ReportSeries.java 100.00% <100.00%> (ø)
...ils/requesthandler/report/CreateReportHandler.java 75.00% <100.00%> (+7.35%) ⬆️
.../api/utils/secretmanager/AwsSecretManagerUtil.java 1.69% <0.00%> (-30.51%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jb-adams jb-adams merged commit 7d5d347 into develop Mar 25, 2022
@jb-adams jb-adams deleted the feature/issue-28-dockerize branch March 25, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize and add docker testing
2 participants