From 5269100e96b9be81854b43b4a1ceb23f841c2ddf Mon Sep 17 00:00:00 2001 From: Gabe Cook Date: Mon, 14 Oct 2024 15:37:32 -0500 Subject: [PATCH] docs(cmd): Add `util.CompleteROM` --- cmd/gones/cmd.go | 5 ++--- cmd/nesutil/ls/cmd.go | 4 +--- internal/util/cobra.go | 7 +++++++ 3 files changed, 10 insertions(+), 6 deletions(-) create mode 100644 internal/util/cobra.go diff --git a/cmd/gones/cmd.go b/cmd/gones/cmd.go index 63b342d0..0d98cc74 100644 --- a/cmd/gones/cmd.go +++ b/cmd/gones/cmd.go @@ -9,6 +9,7 @@ import ( "gabe565.com/gones/cmd/options" "gabe565.com/gones/internal/config" + "gabe565.com/gones/internal/util" "github.com/spf13/cobra" ) @@ -17,10 +18,8 @@ func New(opts ...options.Option) *cobra.Command { Use: "gones ROM", Short: "NES emulator written in Go", RunE: runCobra, - ValidArgsFunction: func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { - return []string{"nes"}, cobra.ShellCompDirectiveFilterFileExt - }, + ValidArgsFunction: util.CompleteROM, SilenceErrors: true, DisableAutoGenTag: true, } diff --git a/cmd/nesutil/ls/cmd.go b/cmd/nesutil/ls/cmd.go index 1b7bf09e..f9ffbe5a 100644 --- a/cmd/nesutil/ls/cmd.go +++ b/cmd/nesutil/ls/cmd.go @@ -39,9 +39,7 @@ func New() *cobra.Command { Aliases: []string{"list"}, RunE: run, - ValidArgsFunction: func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { - return []string{"nes"}, cobra.ShellCompDirectiveFilterFileExt - }, + ValidArgsFunction: util.CompleteROM, } flag := cmd.Flags() diff --git a/internal/util/cobra.go b/internal/util/cobra.go new file mode 100644 index 00000000..89129995 --- /dev/null +++ b/internal/util/cobra.go @@ -0,0 +1,7 @@ +package util + +import "github.com/spf13/cobra" + +func CompleteROM(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) { + return []string{"nes"}, cobra.ShellCompDirectiveFilterFileExt +}