-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't reproduce Figure 3e #2
Comments
Hi! Good catch, there was indeed a small mistake in the script that meant that the model never saw the alternative sequences. We fixed it now, let us know if it works for you! Best, Laura |
Hi Lulu, It should now be fixed, sorry for that. After our refactoring, we accidentally had incoherent settings for reference and motif deleted sequences. We also increased the cache_size argument which should lead to a significant speedup for the motif deletions. Hope that helps! Best, |
Hi Laura and Johannes, I'm sorry for not getting back to you sooner! I am able to reproduce the results now. Thanks so much for your help! Thanks, |
Hi,
Thank you for developing this fantastic tool! I am trying to reproduce Figure 3e. I used the "parallel_inference.py" script from the /scripts/inference_motif_deletions folder to predict the motif effect after mutating all matching sites for GATA1 (motif #10 in the motif table). Using the code in /notebooks/figure3/Figure3.ipynb, I successfully reproduced the predictions for the reference sequences. However, my results for the mutated sequences differ from the example in the notebook. Do you have any suggestions for debugging this issue?
Thanks so much!
The text was updated successfully, but these errors were encountered: