Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompilationLocalJava11Ubuntu test using outdated maven central. #1174

Closed
AaronJhaj opened this issue Sep 8, 2022 · 7 comments
Closed

CompilationLocalJava11Ubuntu test using outdated maven central. #1174

AaronJhaj opened this issue Sep 8, 2022 · 7 comments
Assignees

Comments

@AaronJhaj
Copy link

The CompilationLocalJava11UbuntuIsolated and CompilationLocalJava11UbuntuMvp test pass as they are given a maven repo as a file. However, the CompilationLocalJava11Ubuntu test fails as it looking at maven central repo. The maven central repo is potentially out of date as the error from the test states it cannot find the constructor for the Zos3270Terminal containing the textScanner - suggesting the version for the Zos3270Terminal manager needs to be updated in maven central.

@hobbit1983
Copy link
Member

releasing 0.25.0 will fix this

@AaronJhaj
Copy link
Author

annotated this test class with the GitHubIssueManager. The test should pass with the release of 0.25.0 but until then it will fail due to maven central version.

@AaronJhaj AaronJhaj self-assigned this Sep 16, 2022
@AaronJhaj AaronJhaj reopened this Sep 21, 2022
@AaronJhaj
Copy link
Author

re-opened as GithubIssue annotation won't work unless issue is open

@techcobweb
Copy link
Contributor

Need to re-factor the test to make it useful for us.
@hobbit1983 believes 0.25.0 will fix it. Is this true ?

@AaronJhaj
Copy link
Author

AaronJhaj commented Feb 13, 2023

currently have a pr open galasa-dev/integratedtests#170
However, currently not been able to test the changes due to credential issues and eclipse issues
These changes are to set the gradle.properties file to be pointing at the latest development version of the obr so it isn't only looking at maven central. This is so if there are changes to the managers, the test will will pick it up rather than waiting for the next release.

@techcobweb techcobweb assigned jadecarino and unassigned AaronJhaj Feb 20, 2023
@jadecarino
Copy link

jadecarino commented Feb 22, 2023

Trying to run this locally has proved more challenging that I thought. I have been attempting to run this test locally from my command line using the command below:

java -jar /Users/jadecarino/.galasa/lib/0.25.0/galasa-boot-0.24.0.jar --localmaven file:/Users/jadecarino/.m2/repository --remotemaven https://development.galasa.dev/main/maven-repo/obr --bootstrap file:/Users/jadecarino/.galasa/bootstrap.properties --overrides file:/Users/jadecarino/.galasa/overrides.properties --obr https://development.galasa.dev/main/maven-repo/obr/dev/galasa/dev.galasa.uber.obr/0.26.0/dev.galasa.uber.obr-0.26.0.obr --obr mvn:dev.galasa/dev.galasa.inttests.obr/0.26.0/obr --test dev.galasa.inttests/dev.galasa.inttests.compilation.simbank.local.online.CompilationLocalJava11Ubuntu

(To do this you would first need to build the inttests repo and obr so both are in your local maven repository)

I have added multiple properties into my overrides.properties and credentials.properties - firstly to allow me to connect to a Linux instance, and secondly to point to a downloadable Java archive (in this instance one for Java 11) which this test requires.

I had to add the certificate for artifactory where the Java archive is stored into my cacerts to allow me to download it in my JVM, as I was getting "PKIX path building failed" and "unable to find valid certification path to requested target" prior to this.

I have now got to the point during the Provision Build phase where it attempts to retrieve the Java archive and is just 'hanging' (not sure the technical term for this):
22/02/2023 15:34:13.411 INFO d.g.f.TestRunner - Starting Provision Build phase 22/02/2023 15:34:14.735 DEBUG d.g.j.u.s.JavaUbuntuInstallationImpl - Java archive for tag PRIMARY is being retrieved 22/02/2023 15:35:13.453 DEBUG d.g.i.s.SSHClient - SSH Client unused after 60000 milliseconds, freeing session

I will have to pause this for now as I am switching over to my new laptop which will inevitably require set up before I can continue from the same stage.

@jadecarino jadecarino assigned AaronJhaj and unassigned jadecarino Mar 9, 2023
@AaronJhaj
Copy link
Author

AaronJhaj commented Mar 17, 2023

I have made changes to AbstractCompilationLocalSimBank.java which this tests inherits. A grade.properties file is created which holds the main/maven-repo/obr location so any changes that effect simbank will be captured rather than only looking at maven central, relying on changes to be released - which is what initially caused this test to fail.
If this test fails again we can make amendments as it is difficult to test if the changes work until there is a change in managers for example that would effect this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants