From 873b08f3fecf06bc543e83026f9af65ad26eb40b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gr=C3=BCning?= <bjoern@gruenings.eu>
Date: Sun, 27 Aug 2023 11:33:33 +1000
Subject: [PATCH 1/2] add a few more snippets

I hope this is useful, its needs a careful review. I did this on-the-fly. With example outputs covered, we can actually generate an entire tool just with snippets, which is super useful in demonstrations.
---
 client/src/snippets.json | 46 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index 2d826c49..5298a4d1 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -183,5 +183,49 @@
             "</xrefs>"
         ],
         "description": "Add a xref section with bio.tools type."
-    }
+    },
+    "single output": {
+        "prefix": "gx-output-single",
+        "body": [
+            "<data name=\"--$1\" format=\"$2\" label=\"${tool.name} on ${on_string}\" />"
+        ],
+        "description": "Add a simple single output."
+    },
+    "single output picked up from the working directory": {
+        "prefix": "gx-output-single-from-work-dir",
+        "body": [
+            "<data name=\"--$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\" />"
+        ],
+        "description": "Add a simple single output, that is picked up from the job working directory."
+    },
+    "single tabular output with column-metadata": {
+        "prefix": "gx-output-single-tabular-with-metadata",
+        "body": [
+            "<data name=\"--$1\" format=\"tabular\" from_work_dir=\"$2\" label=\"${tool.name} on ${on_string}\">",
+            "    <actions>",
+            "        <action name=\"column_names\" type=\"metadata\" default=\"$3,$4,$5\"/>",
+            "    </actions>"
+        ],
+        "description": "Add a single tabular output and specify the column names as metadata."
+    },
+    "single optional output with filters": {
+        "prefix": "gx-output-single-filter",
+        "body": [
+            "<!-- TODO: filters needs to be adopted, see examples at https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-outputs-data-filter -->",
+            "<data name=\"--$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\">",
+            "    <filter>condintional_name['select_name'] == 'advanced' and conditional_name['boolean_parameter_name']</filter>",
+            "</data>"
+        ],
+        "description": "Add a optional output with filters."
+    },
+    "dynamic number of outputs in a collections": {
+        "prefix": "gx-output-dynamic-collection",
+        "body": [
+            "<!-- TODO: creating dynamic outputs with collections is covered in depth in the planemo documentation at https://planemo.readthedocs.io/en/latest/writing_advanced.html#collections -->",
+            "<collection name=\"--$1\" type=\"list\" label=\"$2\">",
+            "    <discover_datasets pattern=\"__name_and_ext__\" directory=\"$3\" />",
+            "</collection>"
+        ],
+        "description": "Dynamic number of outputs in a collection."
+    }    
 }

From 4f0d7adb15de249e6f91bd865946c4ecfdf00031 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gr=C3=BCning?= <bjoern@gruenings.eu>
Date: Sun, 27 Aug 2023 20:58:41 +1000
Subject: [PATCH 2/2] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
---
 client/src/snippets.json | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/client/src/snippets.json b/client/src/snippets.json
index 5298a4d1..fd13f796 100644
--- a/client/src/snippets.json
+++ b/client/src/snippets.json
@@ -187,32 +187,33 @@
     "single output": {
         "prefix": "gx-output-single",
         "body": [
-            "<data name=\"--$1\" format=\"$2\" label=\"${tool.name} on ${on_string}\" />"
+            "<data name=\"$1\" format=\"$2\" label=\"${tool.name} on ${on_string}\" />"
         ],
         "description": "Add a simple single output."
     },
     "single output picked up from the working directory": {
         "prefix": "gx-output-single-from-work-dir",
         "body": [
-            "<data name=\"--$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\" />"
+            "<data name=\"$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\" />"
         ],
         "description": "Add a simple single output, that is picked up from the job working directory."
     },
     "single tabular output with column-metadata": {
         "prefix": "gx-output-single-tabular-with-metadata",
         "body": [
-            "<data name=\"--$1\" format=\"tabular\" from_work_dir=\"$2\" label=\"${tool.name} on ${on_string}\">",
+            "<data name=\"$1\" format=\"tabular\" from_work_dir=\"$2\" label=\"${tool.name} on ${on_string}\">",
             "    <actions>",
             "        <action name=\"column_names\" type=\"metadata\" default=\"$3,$4,$5\"/>",
-            "    </actions>"
+            "    </actions>",
+            "</data>"
         ],
         "description": "Add a single tabular output and specify the column names as metadata."
     },
     "single optional output with filters": {
         "prefix": "gx-output-single-filter",
         "body": [
-            "<!-- TODO: filters needs to be adopted, see examples at https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-outputs-data-filter -->",
-            "<data name=\"--$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\">",
+            "<!-- TODO: filters need to be adapted, see examples at https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-outputs-data-filter -->",
+            "<data name=\"$1\" format=\"$2\" from_work_dir=\"$3\" label=\"${tool.name} on ${on_string}\">",
             "    <filter>condintional_name['select_name'] == 'advanced' and conditional_name['boolean_parameter_name']</filter>",
             "</data>"
         ],
@@ -222,7 +223,7 @@
         "prefix": "gx-output-dynamic-collection",
         "body": [
             "<!-- TODO: creating dynamic outputs with collections is covered in depth in the planemo documentation at https://planemo.readthedocs.io/en/latest/writing_advanced.html#collections -->",
-            "<collection name=\"--$1\" type=\"list\" label=\"$2\">",
+            "<collection name=\"$1\" type=\"list\" label=\"$2\">",
             "    <discover_datasets pattern=\"__name_and_ext__\" directory=\"$3\" />",
             "</collection>"
         ],