Rename helper functions

Author: jdavcs

lib/galaxy/model/database_object_names.py

@@ -21,21 +21,21 @@
 }
 
 
-def foreign_key(table_name: str, column_names: Union[str, List]) -> str:
+def build_foreign_key_name(table_name: str, column_names: Union[str, List]) -> str:
     columns = _as_str(column_names)
     return f"{table_name}_{columns}_fkey"
 
 
-def unique_constraint(table_name: str, column_names: Union[str, List]) -> str:
+def build_unique_constraint_name(table_name: str, column_names: Union[str, List]) -> str:
     columns = _as_str(column_names)
     return f"{table_name}_{columns}_key"
 
 
-def check_constraint(table_name: str, column_name: str) -> str:
+def build_check_constraint_name(table_name: str, column_name: str) -> str:
     return f"{table_name}_{column_name}_check"
 
 
-def index(table_name: str, column_names: Union[str, List]) -> str:
+def build_index_name(table_name: str, column_names: Union[str, List]) -> str:
     columns = _as_str(column_names)
     return f"ix_{table_name}_{columns}"
 

lib/galaxy/model/migrations/alembic/versions_gxy/3a2914d703ca_add_index_wf_r_s_s__workflow_invocation_.py

@@ -5,7 +5,7 @@
 Create Date: 2023-03-07 15:06:55.682273
 
 """
-from galaxy.model.database_object_names import index
+from galaxy.model.database_object_names import build_index_name
 from galaxy.model.migrations.util import (
     create_index,
     drop_index,
@@ -19,7 +19,7 @@
 
 table_name = "workflow_request_step_states"
 column_name = "workflow_invocation_id"
-index_name = index(table_name, column_name)
+index_name = build_index_name(table_name, column_name)
 
 
 def upgrade():

lib/galaxy/model/migrations/alembic/versions_gxy/caa7742f7bca_add_index_wf_r_i_p__workflow_invocation_.py

@@ -5,7 +5,7 @@
 Create Date: 2023-03-07 15:10:44.943542
 
 """
-from galaxy.model.database_object_names import index
+from galaxy.model.database_object_names import build_index_name
 from galaxy.model.migrations.util import (
     create_index,
     drop_index,
@@ -20,7 +20,7 @@
 
 table_name = "workflow_request_input_parameters"
 column_name = "workflow_invocation_id"
-index_name = index(table_name, column_name)
+index_name = build_index_name(table_name, column_name)
 
 
 def upgrade():

lib/galaxy/model/migrations/alembic/versions_gxy/d0583094c8cd_add_quota_source_labels.py

@@ -13,7 +13,7 @@
     String,
 )
 
-from galaxy.model.database_object_names import index
+from galaxy.model.database_object_names import build_index_name
 from galaxy.model.migrations.util import (
     add_column,
     create_index,
@@ -32,8 +32,8 @@
 branch_labels = None
 depends_on = None
 
-old_index_name = index("default_quota_association", "type")
-new_index_name = index("quota", "quota_source_label")
+old_index_name = build_index_name("default_quota_association", "type")
+new_index_name = build_index_name("quota", "quota_source_label")
 unique_constraint_name = "uqsu_unique_label_per_user"  # leave unchanged
 
 

lib/galaxy/model/migrations/alembic/versions_gxy/e0e3bb173ee6_add_column_deleted_to_api_keys.py

@@ -10,7 +10,7 @@
     Column,
 )
 
-from galaxy.model.database_object_names import index
+from galaxy.model.database_object_names import build_index_name
 from galaxy.model.migrations.util import (
     add_column,
     drop_column,
@@ -28,7 +28,7 @@
 # database object names used in this revision
 table_name = "api_keys"
 column_name = "deleted"
-index_name = index(table_name, column_name)
+index_name = build_index_name(table_name, column_name)
 
 
 def upgrade():