Skip to content

Conversation

@nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Dec 2, 2025

Fix #21375 .

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member Author

nsoranzo commented Dec 2, 2025

I suspect I am hitting fastapi/fastapi#14376 , as the OpenAPI linting tests pass on my fork.

Edit: And in fact, they passed with a rerun.

@nsoranzo
Copy link
Member Author

nsoranzo commented Dec 2, 2025

Integration test failure unrelated.

url?: string | null;
};
/** DatasetHash */
galaxy__tool_util_models__parameters__DatasetHash: {
Copy link
Member

@mvdbeek mvdbeek Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably have different names ? This one is the hash as specified by a user, the other one describe the actual hash. galaxy__tool_util_models__parameters__DatasetHash seems like something that will change in the future, but we'd like to be able to have a somewhat stable schema.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand how these names are picked by fastapi.
The DatasetPermissions one is even more obscure, as the only other Python class with the same name is in galaxy.model.
If you have any pointer or suggestion on how to fix them, that would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix FastAPI Version Incompat

3 participants