Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Multiple token sending is missing (cw-ICS721) #344

Open
giansalex opened this issue Mar 9, 2023 · 1 comment
Open

BUG: Multiple token sending is missing (cw-ICS721) #344

giansalex opened this issue Mar 9, 2023 · 1 comment
Labels
ics-721 Possible protocol vulnerability improv wasm

Comments

@giansalex
Copy link
Contributor

According to the ICS721 spec, multiple tokenIDs can be sent in the same IBC packet, the nft-transfer module supports this, but cw-ics721 although it allows receiving multiple tokens, it does not allow sending multiple tokens.

e.g: In the following Tx, approve, revoke are executed in cw721, and transfer in cw-ics721

{ 
 "messages": [
  {
    "approve_all": {
      "operator": "ics721-addr"
    }
  },
  {
    "transfer_nft": {
      "contract": "cw721-addr",
      "token_ids": ["token1", "token2", "token3"],
      "channel_id": "channel-1",
      "receiver": "iaa1...",
      "timeout": {
        "timestamp": 1234567890
      },
    }
  },
  {
    "revoke_all": {
      "operator": "ics721-addr"
    }
  }
]}

demo code

@taramakage taramakage added ics-721 Possible protocol vulnerability improv wasm labels Mar 27, 2023
@taramakage
Copy link
Member

Hi @0xekez, can you confirm this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ics-721 Possible protocol vulnerability improv wasm
Projects
None yet
Development

No branches or pull requests

2 participants