From 71471c3576034f32d428bcd30cb2c1c85c0a2b9c Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 4 Sep 2025 17:52:54 +0200 Subject: [PATCH] Require setup-gap@v3 to simplify some code --- .github/workflows/CI.yml | 2 +- README.md | 12 ++++++++---- action.yml | 16 ---------------- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 07ce718..3c9bd0a 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -27,7 +27,7 @@ jobs: - uses: actions/checkout@v5 with: path: this-action/ - - uses: gap-actions/setup-gap@v2 + - uses: gap-actions/setup-gap@v3 - uses: ./this-action/ with: use-latex: ${{ matrix.use-latex }} diff --git a/README.md b/README.md index 76825af..6ab967d 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,10 @@ All of the following inputs are optional. treated as errors - default: `true` +### What's new in v2 + +This action now requires `gap-actions/setup-gap@v3`. + ### Examples See below for @@ -49,8 +53,8 @@ jobs: steps: - uses: actions/checkout@v5 - - uses: gap-actions/setup-gap@v2 - - uses: gap-actions/build-pkg-docs@v1 + - uses: gap-actions/setup-gap@v3 + - uses: gap-actions/build-pkg-docs@v2 ``` #### Uploading the manual as an artifact @@ -70,8 +74,8 @@ jobs: steps: - uses: actions/checkout@v5 - - uses: gap-actions/setup-gap-for-packages@v2 - - uses: gap-actions/build-pkg-docs@v1 + - uses: gap-actions/setup-gap@v3 + - uses: gap-actions/build-pkg-docs@v2 with: use-latex: 'true' - name: 'Upload documentation' diff --git a/action.yml b/action.yml index 6f5ef75..8fa2678 100644 --- a/action.yml +++ b/action.yml @@ -19,22 +19,6 @@ runs: run: | sudo apt-get update sudo apt-get install --no-install-recommends texlive-latex-base texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended - - name: "Setup GAP root" - shell: bash - run: | - # set up a custom GAP root containing only this package, so that - # we can force GAP to load the correct version of this package - # (we already did that in build_pkg.sh, but we do it again here, - # to allow the occasional instance where a package wants to also - # run the tests of others packages, by invoking this script multiple - # times in different directories) - mkdir -p /tmp/gaproot/pkg/ - ln -f -s $PWD /tmp/gaproot/pkg/ - - # start GAP with custom GAP root, to ensure correct package version is loaded - GAPROOT=${GAPROOT-$HOME/gap} - echo "GAP=$GAPROOT/gap -l /tmp/gaproot; --quitonbreak" >> "$GITHUB_ENV" - echo "GAPROOT=$GAPROOT" >> "$GITHUB_ENV" - name: "Check for GAP manual" shell: bash run: |