Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

The Machine objects should not be deployed in the shoot namespace. #2

Closed
krgostev opened this issue Mar 2, 2022 · 3 comments
Closed
Assignees
Labels
lifecycle/stale Nobody worked on this for 6 months (will further age) status/closed Issue is closed (either delivered or triaged)

Comments

@krgostev
Copy link

krgostev commented Mar 2, 2022

Currently the machine objects are deployed in the shoot namespace in the seed. This is not compatible with the control plane migration, because at the end of the migration that namespace is deleted and with it all machine objects. This is not desired in a scenario with control plane migration, so the the machine objects should be created in a different namespace, most probably dedicated only for them.

cc @plkokanov @rfranzke

@krgostev krgostev self-assigned this Mar 2, 2022
@rfranzke
Copy link
Contributor

rfranzke commented Mar 2, 2022

Does this matter much for the CPM? Can't this be treated as implementation detail of how machines work for the local provider? In the end, all that matters (from g/g's PoV) is that the Machine object is migrated and that the cluster is healthy again, right?

@plkokanov
Copy link

I see how this can be implementation dependant, but one of the requirements for the control plane migration was that the nodes do not get recreated during the procedure. Otherwise we could miss issues like this one: gardener/gardener#5423

@rfranzke
Copy link
Contributor

rfranzke commented Mar 9, 2022

Let's start simple for now and then make increments as needed. Let's get the local e2e test done for CPM first.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 6, 2022
@rfranzke rfranzke closed this as completed May 4, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Nobody worked on this for 6 months (will further age) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

4 participants