Do not leak github credentials on failed rotation

zkdev · zkdev · commit 9888231c4115 · 2025-01-16T09:03:25.000+01:00
diff --git a/cfg_mgmt/github.py b/cfg_mgmt/github.py
@@ -187,7 +187,7 @@ def rotate_cfg_element(
             else:
                 logger.info(
                     'No secondary oAuth token provided for credential with username '
-                    f"'{credential.username}' of github-config '{cfg_to_rotate.name()}' "
+                    f"'{credential.username()}' of github-config '{cfg_to_rotate.name()}' "
                     '- will not attempt rotation.'
                 )
         except requests.exceptions.HTTPError as http_error:

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ def rotate_cfg_element(`
`187`	`187`	`else:`
`188`	`188`	`logger.info(`
`189`	`189`	`'No secondary oAuth token provided for credential with username '`
`190`		`- f"'{credential.username}' of github-config '{cfg_to_rotate.name()}' "`
	`190`	`+ f"'{credential.username()}' of github-config '{cfg_to_rotate.name()}' "`
`191`	`191`	`'- will not attempt rotation.'`
`192`	`192`	`)`
`193`	`193`	`except requests.exceptions.HTTPError as http_error:`