Skip to content

Commit d83592e

Browse files
authored
Merge pull request #72 from gatewayapps/version/bump-2.1
bumped version and fixed issues with applying filters
2 parents 3783605 + 87e471d commit d83592e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

app.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function initializeExtension() {
8080

8181
function saveAppliedFilters(urlObj) {
8282
// this check should indicate there are applied filters other than the defaults
83-
if (urlObj.url.indexOf('q=')) {
83+
if (urlObj.url.indexOf('q=') > 0) {
8484
// save the filter querystring for when/if we navigate back
8585
var url = urlObj.url
8686
var querystring = url.substring(url.indexOf('q='))
@@ -91,7 +91,7 @@ function saveAppliedFilters(urlObj) {
9191
if (item.filters !== querystring) {
9292
chrome.storage.sync.set({
9393
filters: querystring
94-
}, () => { })
94+
}, () => { console.log('filters saved') })
9595
}
9696
})
9797
}
@@ -234,7 +234,6 @@ function commentOnIssue(repo, oldIssue, newIssue) {
234234
function goToIssueList(repo, issueNumber, org, oldRepo) {
235235
// based on user settings, determines if the issues list will open after a clone or not
236236
chrome.runtime.sendMessage({ repo: repo, issueNumber: issueNumber, organization: org, oldRepo: oldRepo }, (response) => {
237-
console.log(response.farewell)
238237
})
239238
}
240239

background.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
3131
if(item.createTab) {
3232
chrome.tabs.create({ url: 'https://github.com/' + request.repo + '/issues/' + request.issueNumber, selected: false })
3333
}
34-
chrome.tabs.update(tabs[0].id, { url: 'https://github.com/' + request.organization + '/' + request.oldRepo + '/issues?' + filters, selected: true })
34+
chrome.tabs.update(tabs[0].id, { url: 'https://github.com/' + request.organization + '/' + request.oldRepo + '/issues?' + item.filters, selected: true })
3535
}, 1000)
3636
})
3737
}
3838
else {
39+
console.log('no navigation')
3940
if(item.createTab) {
4041
// if user setting is not set, open open cloned issue in new tab and set focus to that tab
4142
setTimeout(() => { chrome.tabs.create({ url: 'https://github.com/' + request.repo + '/issues/' + request.issueNumber, selected: true }) }, 1000)

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"webNavigation",
3434
"*://github.com/*"
3535
],
36-
"version": "2.0",
36+
"version": "2.1",
3737
"web_accessible_resources":[
3838
"icons/*.png",
3939
"bootstrap/js/bootstrap.min.js",

0 commit comments

Comments
 (0)